Fix passkey autofocus issue in client helpers#36
Open
tsunoyu wants to merge 1 commit intoGoogleChromeLabs:mainfrom
Open
Fix passkey autofocus issue in client helpers#36tsunoyu wants to merge 1 commit intoGoogleChromeLabs:mainfrom
tsunoyu wants to merge 1 commit intoGoogleChromeLabs:mainfrom
Conversation
Collaborator
|
Did you confirm that this code is excuted when you load |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
Loadinghelper class insrc/client/helpers/index.tsto correctly manage standard HTMLinputelements alongsidemdui-text-fieldweb components.The "Passkey form autofill" flow (
passkey-form-autofill.html) relies on theautofocusattribute to automatically trigger the browser's WebAuthn conditional UI (the passkey selection prompt) immediately upon page load.Previously, the
Loadinghelper used in the client logic only targetedmdui-text-fieldelements when toggling thedisabledstate. This resulted in incomplete state management for forms containing standard<input>tags (such as hidden password fields or fallback inputs). This state inconsistency prevented the autofocus behavior from correctly triggering the passkey prompt.Changes
src/client/helpers/index.tsquerySelectorAllselector in bothstart()andstop()methods to targetmdui-text-field, inputinstead of justmdui-text-field.disabledproperty is correctly applied to both element types.Testing
/passkey-form-autofill).